-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boolean and/or to bool tensors #2802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess we only need to update the cubecl rev before merging it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
==========================================
+ Coverage 81.68% 81.69% +0.01%
==========================================
Files 851 851
Lines 113800 113982 +182
==========================================
+ Hits 92957 93122 +165
- Misses 20843 20860 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello conflicts 😅
Fearless Nath just pushed the burn-cubecl
refactor to main lol
Also just one very minor comment regarding the IR docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a tiny mistake, otherwise LGTM!
Will merge after the change 🙂
Co-authored-by: Guillaume Lagrange <[email protected]>
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Requires tracel-ai/cubecl#478
Changes
Adds logical and/or operation for boolean tensors.
Testing
Adds a new test for the new operations.