Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean and/or to bool tensors #2802

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Conversation

wingertge
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Requires tracel-ai/cubecl#478

Changes

Adds logical and/or operation for boolean tensors.

Testing

Adds a new test for the new operations.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we only need to update the cubecl rev before merging it.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.69%. Comparing base (d9e4146) to head (d1453f1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tch/src/ops/bool_tensor.rs 0.00% 18 Missing ⚠️
crates/burn-autodiff/src/ops/bool_tensor.rs 0.00% 6 Missing ⚠️
crates/burn-cubecl/src/kernel/binary.rs 33.33% 4 Missing ⚠️
...ates/burn-cubecl/src/fusion/matmul/optimization.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2802      +/-   ##
==========================================
+ Coverage   81.68%   81.69%   +0.01%     
==========================================
  Files         851      851              
  Lines      113800   113982     +182     
==========================================
+ Hits        92957    93122     +165     
- Misses      20843    20860      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello conflicts 😅
Fearless Nath just pushed the burn-cubecl refactor to main lol

Also just one very minor comment regarding the IR docstring

@wingertge wingertge marked this pull request as ready for review February 13, 2025 22:30
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a tiny mistake, otherwise LGTM!

Will merge after the change 🙂

@laggui laggui merged commit 2c4c039 into tracel-ai:main Feb 14, 2025
11 checks passed
@wingertge wingertge deleted the feat/bool-and-or branch February 14, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants