feat: Added update-datapack in-game command. Running will trigger a script to run on host and restart builders server.
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added shadowJar artifact which bundles jedis library - shadowJar is 96mb compared to base mod 1.5mb - still has kotlin language adapter error despite AgroNet.kt L51 bundling entire thing - ./gradlew runServer WORKS but copying jar to server and running there DOES NOT WORK - this required shadow jar to fix because Jedis library was not included in compiled jar.
…ies to match dungeon server
4Ply
approved these changes
Jan 31, 2024
| response = "Failed to send message" | ||
| } | ||
| logger.info("[AGRONET]: [update-datapack]: $response") | ||
| // context.source.player?.sendMessage(response, Formatting.GRAY) |
There was a problem hiding this comment.
The source should get the response information as well, otherwise we have to check server logs to debug
You should be able to just send that directly to the source, regardless of whether or not it's a player with context.source.sendMessage(...)
| logger.info("Successfully established a socket connection to Redis.") | ||
| } catch (e: Exception) { | ||
| logger.error("Failed to establish a socket connection to Redis: ${e.message}") | ||
| e.printStackTrace() |
There was a problem hiding this comment.
We should throw this error here or just return, so that we don't try the next block of code if this connection fails
There was a problem hiding this comment.
I'll put in an error message and return early
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.