feat(SavePlayerDeck): saves the player's deck to dunga dunga #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyMichael
force-pushed
the
4-citadel-support-modification-of-players-deck-whilst-in-lobby-server
branch
from
c319e2a to
12d80fa
Compare
remove debug logs remove debug logs use NBT data to determine if the item is a deck or a card
CaseyMichael
force-pushed
the
4-citadel-support-modification-of-players-deck-whilst-in-lobby-server
branch
from
12d80fa to
a5c877a
Compare
CaseyMichael
commented
Jan 7, 2024
| @@ -115,8 +115,7 @@ class GiveShulkerCommand( | |||
| val nameJson = "{\"color\":\"${it.colour}\",\"text\":\"${it.displayName}\"}" | |||
| tag.set(nameJson, "display", "Name") | |||
| tag.set("{\"color\":\"${it.colour}\",\"OriginalName\":\"${nameJson}\"}", "display", "NameFormat"); | |||
| // NameFormat: {color: "gray", OriginalName: '{"color":"gray","text":"✲ Moment of Clarity ✲"}', | |||
| // ModifiedName: '{"color":"gray","text":"✲ Moment of Clarity ✲"}'} | |||
| tag.set(it.key, TAG_CARD_KEY) | |||
There was a problem hiding this comment.
added card key so that we can use this to determine if an item is a decked out card
There was a problem hiding this comment.
This might break in-game hopper filters
There was a problem hiding this comment.
good call i'll back out this change
CaseyMichael
commented
Jan 7, 2024
| @@ -18,4 +21,7 @@ fun CommandSender.sendGreyMessage(message: String) { | |||
| this.sendMessage(Component.text().color(NamedTextColor.GRAY).content(message).build()) | |||
| } | |||
|
|
|||
| fun ItemStack.isDeckedOutShulker() = this.type == Material.CYAN_SHULKER_BOX // TODO: Validate using NBT data; validate that this player owns it | |||
| fun ItemStack.isDeckedOutShulker() = | |||
There was a problem hiding this comment.
After a lot of investigation into NBT data on shulkers I learned that when you place & break a shuler the NBT data gets removed and so the only way we can determine if the shulker box is ours is using the name lookup. This also means we loose any tags like the ownerID and stuff that was put on their originally.
I also tried to add "Lore" text to the name with the ownerID but that didn't seem to work.
4Ply
approved these changes
Jan 15, 2024
4Ply
deleted the
4-citadel-support-modification-of-players-deck-whilst-in-lobby-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trackedout/agronet-fabric#14 needs to merge first