Skip to content

Commit

Permalink
cloud-pre.yml: use 4096 bits for ssh rsa key (#14674)
Browse files Browse the repository at this point in the history
The ssh-key we generated used 2048 bits while even openssh's ssh-keygen defaults to 3072 nowadays [0].

While RSA-2048 is probably ok (?) and what NIST recommends for keys until around 2030, its probably better to switch to more bits.

This is also just a temporary solution as we should also switch to ed25519.

Thanks to Dan M (@dmur1 or [email protected]) for pointing this out.

[0] https://github.com/openssh/openssh-portable/blob/19d3ee2f3adf7d9a606ff015c1e153744702c4c9/ssh-keygen.c#L83
  • Loading branch information
disconnect3d authored Dec 12, 2023
1 parent 67aa5fe commit c9352a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion playbooks/cloud-pre.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
- name: Generate the SSH private key
openssl_privatekey:
path: "{{ SSH_keys.private }}"
size: 2048
size: 4096
mode: "0600"
type: RSA

Expand Down

0 comments on commit c9352a1

Please sign in to comment.