Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix Dockerfile to build with llvm 18 #576

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

kumarak
Copy link
Member

@kumarak kumarak commented Jan 17, 2025

No description provided.

@kumarak kumarak requested a review from artemdinaburg January 17, 2025 04:01
@artemdinaburg
Copy link

Is there a test to validate the build in the Dockerfile works? I have some potential changes to slim it down a bit but I realized I am not sure if it would accidentally break the build.

@kumarak
Copy link
Member Author

kumarak commented Jan 20, 2025

Is there a test to validate the build in the Dockerfile works? I have some potential changes to slim it down a bit but I realized I am not sure if it would accidentally break the build.

@artemdinaburg, There is no CI to test the docker build. You can commit the changes here.

@artemdinaburg
Copy link

So this one builds for me and works for the project i want; but I think i would still be a good idea to add a tiny sample project to at least make sure mx-index works and then do something like mx-list-functions to make sure its non-empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants