Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating multiple locales when preparing store version #31

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Allow updating multiple locales when preparing store version #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions lib/app_store/connect.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,21 +178,7 @@ def prepare_release(build_number:, version:, is_phased_release:, metadata:, is_f
latest_version = create_app_store_version(version, build)
end

locale = latest_version.app_store_version_localizations.find { |l| metadata[:locale] == l.locale }
raise LocalizationNotFoundError if locale.nil?

locale_params = if metadata[:whats_new].nil? || metadata[:whats_new].empty?
{"whatsNew" => "The latest version contains bug fixes and performance improvements."}
else
{"whatsNew" => metadata[:whats_new]}
end

unless metadata[:promotional_text].nil? || metadata[:promotional_text].empty?
locale_params["promotionalText"] = metadata[:promotional_text]
end

log "Updating locale for the app store version", {locale: locale.to_json, params: locale_params}
locale.update(attributes: locale_params)
metadata.each { update_version_locale!(latest_version, _1) }

if is_phased_release && latest_version.app_store_version_phased_release.nil?
log "Creating phased release for the app store version"
Expand Down Expand Up @@ -504,6 +490,24 @@ def create_app_store_version(version, build)
end
end

def update_version_locale!(app_store_version, metadata)
locale = app_store_version.app_store_version_localizations.find { |l| metadata[:locale] == l.locale }
return if locale.nil?

locale_params = if metadata[:whats_new].nil? || metadata[:whats_new].empty?
{"whatsNew" => "The latest version contains bug fixes and performance improvements."}
else
{"whatsNew" => metadata[:whats_new]}
end

unless metadata[:promotional_text].nil? || metadata[:promotional_text].empty?
locale_params["promotionalText"] = metadata[:promotional_text]
end

log "Updating locale for the app store version", {locale: locale.to_json, params: locale_params}
locale.update(attributes: locale_params)
end

# no of api calls: 1
def update_version_details!(app_store_version, version, build)
attempts ||= 1
Expand Down
Loading