Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike on Spiker has the wrong positioning when rejoining the server #2274

Open
mugg91 opened this issue Dec 28, 2024 · 2 comments · May be fixed by #2271 or #2275
Open

Spike on Spiker has the wrong positioning when rejoining the server #2274

mugg91 opened this issue Dec 28, 2024 · 2 comments · May be fixed by #2271 or #2275
Labels
bug An *objective* unintended feature/mechanic that should be fixed

Comments

@mugg91
Copy link
Contributor

mugg91 commented Dec 28, 2024

Description

So I think this issue is noteworthy that it warrants an entry.

This issue exists in
the current live build,
in the current dev build with the mechanism PR by @Gingerbeard5773 #2219
and in the obsolete bloody blobs PR by me #1854

Because onSetStatic() in Spiker.as gets run after rejoining, the attachment point offset on spiker gets set to Vec2f(0,-3);.
This code makes sense when first placing the spiker but when rejoining, it could set the offset to this Vec2f even when there already is a spike attached, so it looks incorrect.

It can be fixed by first checking if there already is a spike attached and setting the offset accordingly.

@Gingerbeard5773
Copy link
Contributor

King.Arthur.s.Gold.Build.4762.2024-12-27.20-54-36.mp4

This issue only occurs because your PR is outdated and overwrites changes to the spiker and spikes.

@mugg91
Copy link
Contributor Author

mugg91 commented Dec 28, 2024

@Gingerbeard5773

SpikesLayerBug.mp4

This is a video after directly applying your mechanisms PR. I did no further changes to your code.
I placed spikers and rejoined the server.

@Gingerbeard5773 Gingerbeard5773 linked a pull request Dec 28, 2024 that will close this issue
@Vam-Jam Vam-Jam added the bug An *objective* unintended feature/mechanic that should be fixed label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An *objective* unintended feature/mechanic that should be fixed
Projects
None yet
3 participants