Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] spiker Z layer for vanilla #2275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gingerbeard5773
Copy link
Contributor

resolves #2274

@Gingerbeard5773
Copy link
Contributor Author

@mugg91 you can change up your pr to incorporate this change, i will close this pr in response

@mugg91
Copy link
Contributor

mugg91 commented Dec 28, 2024

Omg, it works.
Ok, I will revert all that stuff I did in #2271 but it might take me a day or two.

@mugg91
Copy link
Contributor

mugg91 commented Dec 30, 2024

Omg, it works. Ok, I will revert all that stuff I did in #2271 but it might take me a day or two.

I tried this solution in #2271 but I noticed a problem.
When spiker is ejected and bloody, then rejoining, then retracting the spiker, its tip wouldn't be bloody (a feature this PR added).
It's likely because when Spike is created, onReceiveCreateData() is called, which calls UpdateSprite(), which tries to update Spiker by fetching its net id from Spike. But it doesn't go through with the update, maybe because Spiker isn't created yet.

I think dealing with this problem would introduce more code to the point where I think the solution I worked out in #2271 might be more satisfying. Instead of updating blood in Spike and Spiker, that PR only updates blood on Spike's sprite, period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spike on Spiker has the wrong positioning when rejoining the server
2 participants