Fix hreflang in source alternate tag #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svaloumas
force-pushed
the
TX-15429_fix_hreflang_in_source_alternate_tag
branch
from
4a6c5d4
to
9985657
Compare
foteinigk
reviewed
Jun 13, 2024
| array_push( $ret, $arr ); | ||
| $firstIteration = false; |
There was a problem hiding this comment.
Just a suggestion, if we would like to avoid declaring variable $firstIteration we could have the following
Suggested change
| $firstIteration = false; | |
| foreach ($languages as $Index => $language) { | |
| ....... | |
| $arr['is_source'] = ($index === 0); | |
| ....... | |
| } |
NOTE: if someone has not updated the plugin yet and source language is not stored at settings, I think we would get the first target language as source
svaloumas
force-pushed
the
TX-15429_fix_hreflang_in_source_alternate_tag
branch
3 times, most recently
from
6c30ec5
to
c5bd7a0
Compare
svaloumas
force-pushed
the
TX-15429_fix_hreflang_in_source_alternate_tag
branch
from
e007504
to
62f6289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.