Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Editor Comments #34

Merged
merged 2 commits into from
Oct 8, 2024
Merged

JOSS Editor Comments #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aae51d
CF-compliant mosaic coordinate attributes #31
Oct 8, 2024
4b20b24
notebooks use plt.show() #23 #33
Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified images/example_mosaic_terrain.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
133 changes: 27 additions & 106 deletions notebooks/flow_aware_hillshade.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

50 changes: 10 additions & 40 deletions notebooks/get_icebergs.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

62 changes: 22 additions & 40 deletions notebooks/mosaic_and_terrain.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

116 changes: 46 additions & 70 deletions notebooks/strip_search_and_dem_difference.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 13 additions & 1 deletion src/pdemtools/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,22 @@ def mosaic(
else:
dem = dems[0]

dems = None # release dem objects for memory management

# Filter -9999.0 values to np.nan
dem = dem.where(dem > -9999.0)

dems = None # release dem objects for memory management
# Enforce CF-compliant names
dem['x'].attrs['axis'] = 'X'
dem['x'].attrs['long_name'] = 'x coordinate of projection'
dem['x'].attrs['standard_name'] = 'projection_x_coordinate'
dem['x'].attrs['units'] = 'metre'

dem['y'].attrs['axis'] = 'Y'
dem['y'].attrs['long_name'] = 'y coordinate of projection'
dem['y'].attrs['standard_name'] = 'projection_y_coordinate'
dem['y'].attrs['units'] = 'metre'

return dem


Expand Down
Loading