Skip to content

Commit

Permalink
Merge pull request #620 from treasure-data/docker-pull-aways-underscore
Browse files Browse the repository at this point in the history
Change docker's pull-aways option to pull_always for consistency
  • Loading branch information
frsyuki authored Aug 11, 2017
2 parents 0fd743c + a6cc460 commit 22198de
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions digdag-docs/src/architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ You can use [Docker](https://www.docker.com/) to run tasks in a container. If `
+step1:
py>: tasks.MyWorkflow.step1

Digdag caches pulled image and reuses it. By default, currently, Digdag uses the cached image consistently even if there is an update. You can set `pull_always: true` option so that Digdag checks update and pulls the latest image of the tag every time when a task starts.

_export:
docker:
image: ubuntu:latest
pull_always: true

+step1:
py>: tasks.MyWorkflow.step1

## Next steps

* [Concepts](concepts.html)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private Process startWithDocker(Path projectPath, TaskRequest request, ProcessBu
}
else {
imageName = baseImageName;
if (dockerConfig.get("pull-always", Boolean.class, false)) {
if (dockerConfig.get("pull_always", Boolean.class, false)) {
pullImage(imageName);
}
}
Expand Down

0 comments on commit 22198de

Please sign in to comment.