Add Microsoft SEH extension to the grammar #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennySun2100
changed the title
DennySun2100
commented
Sep 12, 2023
There was a problem hiding this comment.
@amaanq Could you help look at this change, it is adding Microsoft SEH extension.
DennySun2020
approved these changes
Sep 29, 2023
amaanq
force-pushed
the
dev/dennys/merge_changes
branch
from
645b570
to
4e48003
Compare
|
Alright I collapsed it into one commit and tidied up the test, let me know if that looks good @DennySun2020 |
amaanq
approved these changes
Oct 16, 2023
amaanq
force-pushed
the
dev/dennys/merge_changes
branch
from
4e48003
to
93bf2b3
Compare
|
|
no worries, was just letting you check it out then I'l merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to make c/c++ parser be able to parse Microsoft SEH extension - __try/__except/__finally/__leave. Please refer to "SEH exception handling" in test/corpus/microsoft.txt for the test on this change.