Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HDR and DDS aggregation functions #1246

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Fix HDR and DDS aggregation functions #1246

merged 4 commits into from
Oct 7, 2021

Conversation

mfelsche
Copy link
Member

@mfelsche mfelsche commented Oct 6, 2021

Pull request

Description

Both were issueing invalid numbers on zero elements and were swallowing events when receiving > 8192 elements.

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Didn't test it.

Matthias Wahl added 3 commits October 6, 2021 14:24
Add sum to the returned value and fix some missing values that got dumped when reaching the cache max limit.

Signed-off-by: Matthias Wahl <[email protected]>
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants