Adding abi_stable support for tremor-value, v3
#1336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might want to revert that at some point, when we switch from triggered to paused or so. Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
for turning data chunks from a connector source into (possibly multiple) EventPayloads Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
…gs from file Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
For supporting two-phase startup for bindings (1. connect everything, 2. start sending events), the start_X() methods on Registries needed to be added and we needed to dispatch to different instance implementations as logic is different between artefact types (e.g. connector, pipeline, binding). Starting work on quiescence, but this will be overhauled completely in another commit. Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]> Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
for detecting if we should stop reading from / writing to external connections. Not used yet. See next PR. Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Triggering it with timeout is what is missing now. Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
and bring them in a common shape. Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Matthias Wahl <[email protected]>
Signed-off-by: Daksh Chauhan <[email protected]>
Signed-off-by: Daksh Chauhan <[email protected]>
Signed-off-by: Daksh Chauhan <[email protected]>
Signed-off-by: Daksh Chauhan <[email protected]>
Signed-off-by: Daksh Chauhan <[email protected]>
mfelsche
force-pushed
the
connectors
branch
2 times, most recently
from
a22e761 to
3bcfe47
Compare
marioortizmanero
changed the title
abi_stable support for tremor-value, v3abi_stable support for tremor-value, v4
marioortizmanero
changed the title
abi_stable support for tremor-value, v4abi_stable support for tremor-value, v3
|
Another rebase with crazy changes, starting from scratch at #1381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This is an intermediate PR for #1287 so that it's more manageable.
This is the third attempt for
tremor-value, see #1303 for the first one. Most of these attempts were becauseconnectorsrebased and it was easier to cherry-pick from scratch to resolve the issues.In this PR, all I do is make
tremor-valuecompatible withabi_stable. The main crate will still compile because it's a backward-compatible change. I'll soon make another PR with the changes totremor-runtime, which are much more complicated than this simple PR.Once this is approved and more or less ready, I'll merge marioortizmanero#3 over it with the full PDK changes.
Related
Checklist
Performance