[WIP] PDK support, v2 #1597
Closed
[WIP] PDK support, v2 #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioortizmanero
requested review from
anupdhml,
darach,
Licenser and
mfelsche
as code owners
Licenser
reviewed
May 2, 2022
| @@ -273,6 +278,10 @@ flaky-test = [] | |||
| [patch.crates-io] | |||
| rust-bert = { git = 'https://github.com/mfelsche/rust-bert.git', rev = '1140989' } | |||
| rust_tokenizers = { git = 'https://github.com/mfelsche/rust-tokenizers.git', rev = '5a7860d' } | |||
| # FIXME: update to crates.io when the new version is released | |||
There was a problem hiding this comment.
Putting a note here so we remember to merge those PR's once ready.
marioortizmanero
force-pushed
the
pdk-scratch
branch
2 times, most recently
from
fa1ad43 to
159d402
Compare
marioortizmanero
force-pushed
the
pdk-scratch
branch
from
e1421ee to
4398935
Compare
6 tasks
marioortizmanero
force-pushed
the
pdk-scratch
branch
from
078fe7b to
f6254ab
Compare
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
Signed-off-by: Mario Ortiz Manero <[email protected]>
* Change `World` to `KillSwitch` * Use `FutureExt as _` to avoid name clashes in the future * Fix `KnownKey` issue (see tremor-rs#1812) * Use insert_nocheck when possible Signed-off-by: Mario Ortiz Manero <[email protected]>
marioortizmanero
force-pushed
the
pdk-scratch
branch
from
042b94e to
363e309
Compare
|
closing this as it is too far behind and no longer maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR implements Tremor's plugin system or PDK. This second attempt over #1434 re-organizes a few things, cleans them up, and makes it more flexible for future upgrades (e.g., codec plugins).
NOTE: this is still very WIP, no need to review yet. I don't get why this sends a review automatically to everyone :/
Related
Checklist
I've created this kanban to track my progress: https://github.com/marioortizmanero/tremor-runtime/projects/1
Performance