-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multiple full scan AWS buckets scanning deployment name conflict #128
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Max bucket name length is 63. With prefix included, step function name length will exceed the max length which is 80. Please consider not giving state machine name, and output the name and ARN in the stack outputs for customers to use.
- PR description needs to be completed: update title and change summary
- The branch has unresolved conflict that needs to be resolved
- Use conventional commit message for the commit:
fix: Multiple full scan AWS buckets scanning deployment name conflict
The issue related to this PR should be #120 |
Thanks for the correction on bug number, I missed attaching the correct one. I have resolved the conflict. Shall I make change to control the step function length ? |
Yes, this should be addressed, or it won't work for longer bucket name. I'd suggest not giving default name for the step function. What do you think? |
I have made changes to make sure the length of StateMachine function should be in limit. |
StateMachineName: | ||
Fn::Join: | ||
- "" | ||
- - fullScanSSM- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it SSM
but not SM
? How about we just remove the acronym, since we already know that's a state machine/step function? By the way, would you please also use capital for the first char, like ScannerLoop
?
TITLE
Change Summary
PR Checklist
Other Notes
This is resolution against the bug #121