FW release 2.8.1 #91
Merged
FW release 2.8.1 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @mmilata to review the script, but probably no need to wait for his review. we can modify the script later if there are problems. |
komret
requested changes
Aug 9, 2024
There was a problem hiding this comment.
How about folders 1 and 2? If we stop updating them, we need to adjust the releases check.
firmware/t2t1/releases.json
Outdated
There was a problem hiding this comment.
Please add firmware_revision: 632b9561559b7ab6824bb7eeac072874e07b7b82 for T2T1. We use it for a new security check: trezor/trezor-suite#13495
We'll eventually add it for all models.
| import click | ||
| from trezorlib import firmware | ||
|
|
||
| ROOT = Path(__file__).parent.parent.resolve() |
There was a problem hiding this comment.
The URLs should start with data/firmware/, but they start with firmware/
matejcik
force-pushed
the
matejcik/release-2.8.1
branch
from
f8f8e66 to
19965b8
Compare
|
changed in force-push (messed up my fixups, sorry.) |
komret
approved these changes
Aug 9, 2024
vdovhanych
approved these changes
Aug 9, 2024
matejcik
force-pushed
the
matejcik/release-2.8.1
branch
from
4e7f80d to
0a5f404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding a script that can generate releases.json -- sorely needed!
It's still kind of incomplete though.