Skip to content

Commit

Permalink
fix(core/ui): don't swipe left if there is no menu
Browse files Browse the repository at this point in the history
  • Loading branch information
ibz committed Dec 11, 2024
1 parent a0bd486 commit e6802bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions core/.changelog.d/4421.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[T3T1] Fix swiping into empty page.
5 changes: 3 additions & 2 deletions core/embed/rust/src/ui/model_mercury/flow/confirm_action.rs
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ fn new_confirm_action_uni<T: Component + Paginate + MaybeTrace + 'static>(
let mut content = Frame::left_aligned(strings.title, content)
.with_margin(frame_margin)
.with_swipe(Direction::Up, SwipeSettings::default())
.with_swipe(Direction::Left, SwipeSettings::default())
.with_vertical_pages()
.with_footer(
TR::instructions__swipe_up.into(),
Expand All @@ -257,7 +256,9 @@ fn new_confirm_action_uni<T: Component + Paginate + MaybeTrace + 'static>(

match extra {
ConfirmActionExtra::Menu { .. } => {
content = content.with_menu_button();
content = content
.with_menu_button()
.with_swipe(Direction::Left, SwipeSettings::default());
}
ConfirmActionExtra::Cancel => {
content = content.with_cancel_button();
Expand Down

0 comments on commit e6802bd

Please sign in to comment.