Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow splitting translations into per-layout JSONs #4503

Open
wants to merge 4 commits into
base: romanz/translations
Choose a base branch
from

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 15, 2025

This way, we can submit them separately to Crowdin, so that each layout could be translated independently.

Following #4489.

This way, we can submit them separately to Crowdin, so that
each layout could be translated independently.

[no changelog]
@romanz romanz requested a review from obrusvit January 15, 2025 10:08
@romanz romanz self-assigned this Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz
Copy link
Contributor Author

romanz commented Jan 15, 2025

Depends on #4495, to be able to reuse translations.get_translation() function.

@romanz romanz marked this pull request as ready for review January 15, 2025 10:19
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Jan 15, 2025
Removed merging logic since it will be re-implemented by a separate command.
@romanz
Copy link
Contributor Author

romanz commented Jan 15, 2025

The CI failures above are due to 4148e87, which will be removed before merging #4495.

@romanz romanz requested a review from prusnak as a code owner January 15, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: 🏃‍♀️ In progress
Development

Successfully merging this pull request may close these issues.

1 participant