Update electron-updater to 6.5.0 + fix: progress bar for update on linux #15448

peter-sanderson · 2024-11-19T13:26:32Z

Problem is, that for differential downloads, the progress bar is not working correctly (seems to not be implemented for multi-range downloads at all).

Solution is therefore to fallback to direct full download. However, the switch for this is simply not working for AppImage so we have to fix it in Electron Builder first.

Resolves: #14416

This PR is related to this in Electron Repo: download-progress event not firing electron-userland/electron-builder#8659
❗ This fix: use disableDifferentialDownload flag in the AppImageBuilder electron-userland/electron-builder#8695 needs to be finished, merged and released first in the electron builder repo first.

peter-sanderson · 2025-01-02T11:02:15Z

🎉 electron-userland/electron-builder#8695 was merged! Now we need only wait for the release.

peter-sanderson · 2025-02-11T18:38:31Z

coderabbitai · 2025-02-11T18:41:23Z

Walkthrough

The pull request updates the electron-updater dependency from version 6.3.9 to 6.5.0 in both the suite-desktop-core and suite-desktop packages. Additionally, it introduces a new conditional statement in the autoUpdater module of suite-desktop-core that disables differential downloads when the application is running on the Linux platform. These changes involve updating the dependency version and modifying the update mechanism specifically for Linux systems, while no other configurations, dependencies, or exported entities are altered.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62c9c17 and 8627ebe.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (3)

packages/suite-desktop-core/package.json (1 hunks)
packages/suite-desktop-core/src/modules/auto-updater.ts (1 hunks)
packages/suite-desktop/package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

packages/suite-desktop-core/package.json
packages/suite-desktop/package.json
packages/suite-desktop-core/src/modules/auto-updater.ts

⏰ Context from checks skipped due to timeout of 90000ms (19)

GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
GitHub Check: PR-check / node-override init-api-flaky
GitHub Check: PR-check / web-override init-api-flaky
GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
GitHub Check: build-deploy
GitHub Check: build-deploy
GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
GitHub Check: EAS Update
GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
GitHub Check: Setup and Cache Dependencies
GitHub Check: build-web
GitHub Check: build-web
GitHub Check: Analyze with CodeQL (javascript)
GitHub Check: test
GitHub Check: transport-e2e-test
GitHub Check: Socket Security: Pull Request Alerts

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-11T18:42:42Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 26
More info

Learn more about 𝝠 Expo Github Action

peter-sanderson · 2025-02-11T19:08:20Z

QA:

test update flow for all platforms
test all possible update scenarios as the update dependency lib got an upgrade

Lemonexe · 2025-02-12T09:32:08Z

packages/suite/package.json

@@ -1,6 +1,6 @@
 {
    "name": "@trezor/suite",
-    "suiteVersion": "25.3.0",
+    "suiteVersion": "0.0.0",


remove this

Lemonexe

tested linux dev build, progress bar works 👍

…on linux

peter-sanderson force-pushed the progress-bar-linux branch from 363835d to 155b9d5 Compare November 21, 2024 09:20

peter-sanderson force-pushed the progress-bar-linux branch from 155b9d5 to 4691600 Compare December 13, 2024 10:22

peter-sanderson closed this Feb 11, 2025

peter-sanderson force-pushed the progress-bar-linux branch from 4691600 to 5e15f44 Compare February 11, 2025 12:18

peter-sanderson reopened this Feb 11, 2025

peter-sanderson force-pushed the progress-bar-linux branch from e4cd29a to 2fb59bd Compare February 11, 2025 18:38

peter-sanderson marked this pull request as ready for review February 11, 2025 18:38

peter-sanderson requested a review from komret as a code owner February 11, 2025 18:38

peter-sanderson force-pushed the progress-bar-linux branch from 2fb59bd to 4fa1932 Compare February 11, 2025 18:47

peter-sanderson changed the title ~~fix: progress bar for update on linux~~ Update electron-updater to 6.5.0 + fix: progress bar for update on linux Feb 11, 2025

peter-sanderson force-pushed the progress-bar-linux branch from 4fa1932 to 29aba7e Compare February 11, 2025 19:09

Lemonexe reviewed Feb 12, 2025

View reviewed changes

peter-sanderson force-pushed the progress-bar-linux branch from 29aba7e to 62c9c17 Compare February 12, 2025 09:57

Lemonexe approved these changes Feb 12, 2025

View reviewed changes

fix: Update electron-updater to 6.5.0 + fix: progress bar for update …

8627ebe

…on linux

peter-sanderson force-pushed the progress-bar-linux branch from 62c9c17 to 8627ebe Compare February 12, 2025 13:15

peter-sanderson merged commit c4fca3d into develop Feb 12, 2025
71 of 72 checks passed

peter-sanderson deleted the progress-bar-linux branch February 12, 2025 14:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update electron-updater to 6.5.0 + fix: progress bar for update on linux #15448

Update electron-updater to 6.5.0 + fix: progress bar for update on linux #15448

peter-sanderson commented Nov 19, 2024 •

edited

Loading

peter-sanderson commented Jan 2, 2025

peter-sanderson commented Feb 11, 2025

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Feb 11, 2025 •

edited

Loading

peter-sanderson commented Feb 11, 2025

Lemonexe Feb 12, 2025

peter-sanderson Feb 12, 2025

peter-sanderson Feb 12, 2025

Lemonexe left a comment

Update electron-updater to 6.5.0 + fix: progress bar for update on linux #15448

Update electron-updater to 6.5.0 + fix: progress bar for update on linux #15448

Conversation

peter-sanderson commented Nov 19, 2024 • edited Loading

peter-sanderson commented Jan 2, 2025

peter-sanderson commented Feb 11, 2025

coderabbitai bot commented Feb 11, 2025 • edited Loading

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Feb 11, 2025 • edited Loading

peter-sanderson commented Feb 11, 2025

Lemonexe Feb 12, 2025

Choose a reason for hiding this comment

peter-sanderson Feb 12, 2025

Choose a reason for hiding this comment

peter-sanderson Feb 12, 2025

Choose a reason for hiding this comment

Lemonexe left a comment

Choose a reason for hiding this comment

peter-sanderson commented Nov 19, 2024 •

edited

Loading

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 11, 2025 •

edited

Loading