fix: Wait for token definitions in import #16614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
yanascz
reviewed
Jan 27, 2025
suite-native/module-accounts-import/src/accountsImportThunks.ts
Outdated
Show resolved
Hide resolved
yanascz
approved these changes
Jan 27, 2025
vytick
added
no-project
vytick
changed the title
vytick
force-pushed
the
fix/native/imported-token-rates
branch
from
53e3612 to
36d00c9
Compare
|
QA OK Info 25.1.3 9fd0808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing account there was no await for token definitions which could cause fiat values not being shown in case fetch took too long.
This awaits token definitions to be downloaded and triggers fiat rates update to be fetched. So the fiat rates should load gradually once the import confirmation is shown.