Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): unify copy-webpack-plugin default import naming #16943

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Feb 12, 2025

absolute OCD nitpick. unifies mixed naming of CopyPlugin and CopyWebpackPlugin

@mroz22 mroz22 added no-project This label is used to specify that PR doesn't need to be added to a project low hanging fruit Simple, quick task. Doable in 2 hours. labels Feb 12, 2025
Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

The pull request updates the import and instantiation references for the copy-webpack-plugin across multiple webpack configuration files. In each affected file, the module is renamed from CopyPlugin to CopyWebpackPlugin in both the import statements and within the plugins array. The changes span configurations in packages including connect-examples (both development and production builds), connect-explorer, connect-popup, connect-webextension, and suite-build (for desktop and web environments). No modifications have been made to the underlying logic, configuration, or control flow—the adjustments solely standardize the naming convention for the plugin.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1516375 and cb6fa38.

📒 Files selected for processing (7)
  • packages/connect-examples/electron-renderer-with-assets/webpack/config.dev.js (2 hunks)
  • packages/connect-examples/electron-renderer-with-assets/webpack/config.prod.js (2 hunks)
  • packages/connect-explorer/webpack/webextension.webpack.config.ts (2 hunks)
  • packages/connect-popup/webpack/prod.webpack.config.ts (2 hunks)
  • packages/connect-webextension/webpack/inline.webpack.config.ts (2 hunks)
  • packages/suite-build/configs/desktop.webpack.config.ts (2 hunks)
  • packages/suite-build/configs/web.webpack.config.ts (2 hunks)
✅ Files skipped from review due to trivial changes (6)
  • packages/connect-webextension/webpack/inline.webpack.config.ts
  • packages/suite-build/configs/web.webpack.config.ts
  • packages/connect-examples/electron-renderer-with-assets/webpack/config.dev.js
  • packages/connect-explorer/webpack/webextension.webpack.config.ts
  • packages/connect-examples/electron-renderer-with-assets/webpack/config.prod.js
  • packages/suite-build/configs/desktop.webpack.config.ts
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: build-deploy
  • GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=other, trezor-user-env-unix)
  • GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
  • GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
  • GitHub Check: build-web
  • GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: build-web
🔇 Additional comments (2)
packages/connect-popup/webpack/prod.webpack.config.ts (2)

110-130: LGTM! Plugin instantiation matches import.

The plugin instantiation is updated to match the standardized import name while maintaining the same configuration.


2-2: LGTM! Standardizing import name.

The change to use CopyWebpackPlugin aligns with the official package name and improves consistency across the codebase.

Let's confirm this is the official package name:

✅ Verification successful

🌐 Web query:

What is the official name of the copy-webpack-plugin package?

💡 Result:

The official name of the package is copy-webpack-plugin, as shown in its npm registry entries[1][7], webpack documentation[3], and installation commands across multiple sources[1][3][5][7]. The package is maintained under the webpack-contrib GitHub organization[8][9] and follows standard npm naming conventions with kebab-case formatting.

Key evidence:

  • Installation instructions use npm install copy-webpack-plugin[1][3][7]
  • Webpack's documentation lists it as CopyWebpackPlugin (class name) while specifying the package name as lowercase[3]
  • Package.json file in GitHub repository confirms the name[9]

This naming remains consistent across all major versions from v4[5] through v12[1], despite API changes over time.

Citations:


LGTM! Standardizing Import Name.
The change to use CopyWebpackPlugin aligns perfectly with the official usage seen in the documentation—even though the npm package is named copy-webpack-plugin (all lowercase), the class is conventionally imported as CopyWebpackPlugin. This update is consistent with the PR objective and has no functional impact.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@karliatto karliatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful absolute OCD 🥇

@mroz22 mroz22 merged commit 956636d into develop Feb 12, 2025
59 of 61 checks passed
@mroz22 mroz22 deleted the nitpick branch February 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low hanging fruit Simple, quick task. Doable in 2 hours. no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants