detect incorrect KEY=value in env_keep and env_check

trifectatechfoundation · Feb 25, 2025 · 3127edf · 3127edf
1 parent 82dff61
commit 3127edf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/sudoers/ast.rs b/src/sudoers/ast.rs
@@ -721,8 +721,11 @@ impl Parse for defaults::SettingsModifier {
                 make(result)
             } else {
                 let EnvVar(name) = expect_nonterminal(stream)?;
-
-                make(vec![name])
+                if is_syntax('=', stream)? {
+                    unrecoverable!(stream, "double quotes are required for VAR=value pairs")
+                } else {
+                    make(vec![name])
+                }
             }
         };
 

diff --git a/test-framework/sudo-compliance-tests/src/sudo/sudoers/env/check.rs b/test-framework/sudo-compliance-tests/src/sudo/sudoers/env/check.rs
@@ -80,7 +80,6 @@ fn key_value_no_match() -> Result<()> {
 }
 
 #[test]
-#[ignore = "gh345"]
 fn key_value_syntax_needs_double_quotes() -> Result<()> {
     super::key_value_syntax_needs_double_quotes(ENV_LIST)
 }

diff --git a/test-framework/sudo-compliance-tests/src/sudo/sudoers/env/keep.rs b/test-framework/sudo-compliance-tests/src/sudo/sudoers/env/keep.rs
@@ -76,7 +76,6 @@ fn key_value_no_match() -> Result<()> {
 }
 
 #[test]
-#[ignore = "gh345"]
 fn key_value_syntax_needs_double_quotes() -> Result<()> {
     super::key_value_syntax_needs_double_quotes(ENV_LIST)
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,7 +80,6 @@ fn key_value_no_match() -> Result<()> { @@
     }
     #[test]
-    #[ignore = "gh345"]
     fn key_value_syntax_needs_double_quotes() -> Result<()> {
         super::key_value_syntax_needs_double_quotes(ENV_LIST)
     }
@@ Expand Down @@