Use docker run --rm + docker kill instead of docker rm #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike what the comment on docker rm suggested, previously we would actually block on docker rm completing. Using docker run --rm + docker kill only blocks on killing the container while running the slow cleanup in the background. This almost halfs the time it takes to run the compliance tests with podman on Linux. In addition if you kill the compliance test executable itself, the containers will now be gone entirely as soon as you kill the containers rather than leaving data on the disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike what the comment on docker rm suggested, previously we would actually block on docker rm completing. Using docker run --rm + docker kill only blocks on killing the container while running the slow cleanup in the background. This almost halfs the time it takes to run the compliance tests with podman on Linux. In addition if you kill the compliance test executable itself, the containers will now be gone entirely as soon as you kill the containers rather than leaving data on the disk.