Use a ring buffer to pipe data between IO objects #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 57.36% 58.59% +1.22%
==========================================
Files 74 75 +1
Lines 10559 10732 +173
==========================================
+ Hits 6057 6288 +231
+ Misses 4502 4444 -58 ☔ View full report in Codecov by Sentry. |
japaric
approved these changes
Jan 22, 2024
src/exec/use_pty/pipe.rs
Outdated
| // ▲ | ||
| // │ | ||
| // start | ||
| buf.insert(&mut [0u8; HALF_LEN].as_slice()).unwrap(); |
There was a problem hiding this comment.
in this particular case you could set the initial condition by directly setting the value of start to HALF_LEN. that way this unit test does not rely on insert and remove correctly working in cases 1.1 and 2.1.
There was a problem hiding this comment.
Yeah I thought about it but I think I'd rather leave those tests as implementation agnostic as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #617