Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #818 (verified on i386).
Note that the bindgen self-test that I edited don't really add much value: they're essentially testing that the
[repr(C)]
layout is as we expect it to be, but they go a bit beyond what a C compiler would have to guarantee; and even if the layout of these structs is different, it would still mean our PAM bindings would be correct anyway. The only important bit is that the Rust spec given matches the actual C prototypes.Which is a given, since PAM is an extremely stable API.
This can be reviewed commit-by-commit.