Merge pull request #23 from Staffbase/RE-1180-fix-title-on-tabs-load

WIP: RE-1180: Fix title on tabs module load.
trigger-corp · Dec 9, 2019 · ffdfd20 · ffdfd20
2 parents d6def32 + 2d00315
commit ffdfd20
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/inspector/ios-inspector/ForgeModule/tabs_API.m b/inspector/ios-inspector/ForgeModule/tabs_API.m
@@ -170,6 +170,7 @@ + (void) setTitle:(ForgeTask*)task modal:(NSString*)modal title:(NSString*)title
     if (viewController == nil) {
         return;
     }
+    viewController.title = title;
     viewController.navigationBarTitle.title = title;
 }
 

diff --git a/module/ios/module.a b/module/ios/module.a
diff --git a/module/manifest.json b/module/manifest.json
@@ -1,8 +1,8 @@
 {
-    "changes": "* Fixed: Cannot open documents saved locally with `forge.file.saveURL`\n* Fixed: iOS 12 crashes when opening documents saved locally.\n* Fixed: `opaqueTopBar` property does not render properly on iOS 13.2.x.* Fixed: navigation and status bar tints aren't set on iOS when `opaqueTopBar` property is set.",
+    "changes": "* Fixed: Set title on iOS on tabs load",
     "description": "APIs to deal with opening browser tabs and external sites within your app.\n\nThe tabs module allows you to open external sites in an un-trusted popup view that your users can close at any point.",
     "min_platform_version": "v2.8.4",
     "namespace": "tabs",
     "platform_version": "v2.8.4",
-    "version": "3.4.2"
+    "version": "3.4.4"
 }