Code Cleanup + Fixes #6
Open
+83
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from Host and Port to connection_string (initially to use ldapi URI) Also fixed group_identifier spelling
In the Symfony Ldap API, you can choose between the encryption options of 'none', 'ssl', and 'tls'. Using 2 different booleans can cause confusion in intended behavior (what if ssl and start_tls are both enabled).
|
When this gonna be merged? |
|
🤷♂️ @rhukster |
|
Sorry guys.. not had chance to test this yet. We have to be careful it doesn't break existing installs as this pluign in particular was sponsored by a client, we want to make sure that any changes don't break said client... |
|
This is not backward compatible and although the changes proposed are nice we can’t merge if it’s going to break existing instances. Perhaps you could add fallbacks for the settings and defaults you are replacing? |
ViliusS
reviewed
Nov 3, 2020
| DEFAULT_ACCESS_LEVELS_GROUPS: 'Default Groups' | ||
| DEFAULT_ACCESS_LEVELS_SITE: 'Default Site Access' | ||
| DEFAULT_GROUPS_ACCESS_LEVELS: 'Groups Access Level' | ||
| ENCRYPTION: 'Encryption' | ||
| ENCRYPTION_DESC: 'The Encryption Protocol used to connect to the LDAP server' | ||
| ENCRYPTION_METHODS: |
There was a problem hiding this comment.
The options here should say:
- None
- SSL/TLS
- StartTLS
It better represents what is actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group_identifierhostandportoptions toconnection(This allows for other URI's to be used, such asldapi://)sslandstart_tlstoencryption(This matches up better with Symfony's API and makes options clearer)