Corrected functions to compile with VS2022 #13319

ViNN280801 · 2024-08-04T17:24:48Z

@trilinos/kokkos

Motivation

This change addresses a compilation issue under MSVC in Visual Studio 2022. The compiler reports a C2535 error indicating that two overloaded functions are identical, despite having different enable_if conditions. Adding additional conditions to the enable_if clauses ensures that the MSVC compiler can distinguish between the two overloaded functions.

Testing

The changes have been tested locally to ensure that they resolve the compilation issue without affecting the functionality of the code. The functions are covered by existing unit tests in the Kokkos package.

Additional Information

Request for Improved Windows Support

During the process of compiling Trilinos on Windows, I encountered numerous issues related to the build system and compatibility with MSVC in Visual Studio 2022. These challenges included but were not limited to:

Overloaded functions causing compilation errors under MSVC.
Long file path issues that required registry modifications: (Severity Code Description Project File Line Suppression State Details
Error C1083 Cannot open source file: 'C:\Users\vladislavsemykin\Downloads\Trilinos\Trilinos\build\packages\kokkos-kernels\sparse\eti\generated_specializations_cpp\gauss_seidel_symbolic\Sparse_gauss_seidel_symbolic_eti_DOUBLE_ORDINAL_INT_OFFSET_SIZE_T_LAYOUTLEFT_EXECSPACE_SERIAL_MEMSPACE_HOSTSPACE.cpp': No such file or directory kokkoskernels C:\Users\vladislavsemykin\Downloads\Trilinos\Trilinos\build\packages\kokkos-kernels\sparse\eti\generated_specializations_cpp\gauss_seidel_symbolic\Sparse_gauss_seidel_symbolic_eti_DOUBLE_ORDINAL_INT_OFFSET_SIZE_T_LAYOUTLEFT_EXECSPACE_SERIAL_MEMSPACE_HOSTSPACE.cpp 1
). I have this file, but still getting an error, so, I guess that naming is too long.
Difficulty in configuring CMake with the appropriate include and library paths.
and other issues, even "syntax errors" (though I compile it in C++20 and C17 (all the projects)).

Given the increasing use of Windows as a development platform, I kindly request the Trilinos development team to consider making the build process more accessible and robust for Windows users. Enhancements such as detailed Windows-specific build instructions, automated scripts to handle common issues, and pre-configured environment setups would greatly benefit the community.

Thank you for considering this request, and please let me know if there is anything I can do to assist with improving the Windows build process.

…_20240712_180111 Automatically Merged using Trilinos Master Merge AutoTester PR Title: b'Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240712_180111 branch to master' PR Author: trilinos-autotester

…_20240719_180002 Automatically Merged using Trilinos Master Merge AutoTester PR Title: b'Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240719_180002 branch to master' PR Author: trilinos-autotester

…_20240726_180005 Automatically Merged using Trilinos Master Merge AutoTester PR Title: b'Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240726_180005 branch to master' PR Author: trilinos-autotester

cgcgcg · 2024-08-04T17:57:31Z

@ViNN280801 Please open a PR with these changes directly against https://github.com/kokkos/kokkos. For the Kokkos-Kernels specific issue, please report it here: https://github.com/kokkos/kokkos-kernels. We do not test Trilinos on Windows, but since you are building there: would you mind giving more details on the other issues you are seeing? In particular, what syntax errors are there?

ViNN280801 · 2024-08-04T18:10:28Z

@ViNN280801 Please open a PR with these changes directly against https://github.com/kokkos/kokkos. For the Kokkos-Kernels specific issue, please report it here: https://github.com/kokkos/kokkos-kernels. We do not test Trilinos on Windows, but since you are building there: would you mind giving more details on the other issues you are seeing? In particular, what syntax errors are there?

Okay, I'll do that. As for syntax errors, I'm sure it's because of some compiler settings. Because I successfully compiled the entire Trilinos on Fedora 34 and Debian 12, but now I needed to do it on Windows and it turned out to be problematic. Examples of the "syntax errors":
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(33,107): error C2146: syntax error: missing ')' before identifier 'A'
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(33,107): error C3646: 'A': unknown override specifier
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(33,108): error C2988: unrecognizable template declaration/definition
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(33,108): error C2059: syntax error: ','
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(34,91): error C2059: syntax error: ')'
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(34,93): error C2334: unexpected token(s) preceding '{'; skipping apparent function body
31>C:<MYPATH>\Trilinos\Trilinos\packages\shylu\shylu_node\tacho\src\impl\Tacho_Lapack_Team.hpp(69,107): error C2146: syntax error: missing ')' before identifier 'A'

false positives of some kind.

cgcgcg · 2024-08-04T18:29:45Z

@ViNN280801 Could you try replacing __restrict__ with KOKKOS_RESTRICT and see if that fixes it?

@iyamazaki FYI.

ViNN280801 · 2024-08-04T18:34:46Z

@ViNN280801 Could you try replacing __restrict__ with KOKKOS_RESTRICT and see if that fixes it?

@iyamazaki FYI.

just the same

cgcgcg · 2024-08-04T18:42:48Z

@ViNN280801 I think you might have replaced KOKKOS_RESTRICT with __restrict__, not the other way around. KOKKOS_RESTRICT is a macro that resolves to __restrict on Windows, see

Trilinos/packages/kokkos/core/src/Kokkos_Macros.hpp

Lines 195 to 199 in 19640f3

    
           #if defined(_WIN32) 
        
           #define KOKKOS_RESTRICT __restrict 
        
           #else 
        
           #define KOKKOS_RESTRICT __restrict__ 
        
           #endif

ViNN280801 · 2024-08-06T08:48:25Z

@cgcgcg, yes, this solved some of the problems, but I'm still in the process of building for Windows, as soon as it works, I'll provide instructions on how I managed to do it.

cgcgcg · 2024-08-06T13:02:38Z

@ViNN280801 Thanks!

ndellingwood · 2024-08-06T19:26:32Z

The Kokkos changes would need submission of corresponding PR to https://github.com/kokkos/kokkos , and acceptance to the repo before acceptance+merging to Trilinos; adding @dalg24 @crtrott @masterleinad for tracking

trilinos-autotester · 2024-08-06T21:39:39Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

…_20240806_153426 Automatically Merged using Trilinos Master Merge AutoTester PR Title: b'Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240806_153426 branch to master' PR Author: trilinos-autotester

ViNN280801 · 2024-08-07T11:17:23Z

So, I collected some information that I've done to compile almost all the packages (Amesos2, Belos, Intrepid2, Kokkos, KokkosKernels, NOX, ROL, RTOp, Sacado, Shards, Stokhos, Stratimikos, Tacho, Teuchos, Tempus, Thyra, Tpetra, MiniTensor, Adelus, SEACAS, ShyLU, Galeri). I had a lot of compilation issues with C++ std version (changed for all the projects to C++20), problems with FMT support of the utf-8 (added flag /utf-8 to packages that uses FMT). And as I understand in Windows ENVs are not so good as in Linux, and I had to add to multiple packages include&library directories of FMT and MPI. For example:

VS22 printed to me unresolved links and some issues like "Cannot find mpi.h" for <...> package, and I corrected each package manually, like I showed it above.

After the build I have the setup file

What about the code, I changed some files, and I wrote these files with changes:

Fixing fmt issue constant expr in e.txt
Fixing fmt problem in pe_input.C.txt
Modification fmt code in sys_info.C suplib_cpp project.txt
Replaced return type in Intrepid2_DerivedBasis_HVOL_QUAD.hpp.txt
Added enable_if to Tpetra_Import_Util2.hpp.txt
Replaced enable_if in Kokkos_View.hpp.txt

I compile the Trilinos with MSYS2 using the following command (added some flags like utf-8 and c++20 std):

cmake -G "Visual Studio 17 2022" \
      -DCMAKE_BUILD_TYPE=Release \
      -DTrilinos_ENABLE_TESTS=OFF \
      -DTrilinos_ENABLE_ALL_PACKAGES=ON \
      -DTPL_ENABLE_MPI=ON \
      -DTrilinos_ENABLE_Epetra=OFF \
      -DTrilinos_ENABLE_EpetraExt=OFF \
      -DTrilinos_ENABLE_Tpetra=ON \
      -DCMAKE_C_COMPILER=gcc \
      -DCMAKE_CXX_COMPILER=g++ \
      -DMPI_EXEC="C:/Program Files/Microsoft MPI/Bin/mpiexec.exe" \
      -DMPI_C_COMPILER="C:/msys64/mingw64/bin/mpicc.exe" \
      -DMPI_CXX_COMPILER="C:/msys64/mingw64/bin/mpicxx.exe" \
      -DCMAKE_C_FLAGS="/std:c17" \
      -DCMAKE_CXX_FLAGS="/std:c++20 /utf-8" \
      -DCMAKE_INCLUDE_PATH="$ENV{INCLUDE}" \
      -DCMAKE_LIBRARY_PATH="\"C:/Program Files/fmt/lib\";\"C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x64\"" \
      -DCMAKE_EXE_LINKER_FLAGS="/LIBPATH:\"C:/Program Files/fmt/lib\" /LIBPATH:\"C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x64\"" \
      ..

But before I did this:

pacman -Syu

pacman -S mingw-w64-x86_64-toolchain mingw-w64-x86_64-cmake mingw-w64-x86_64-cmake mingw-w64-x86_64-msmpi

mingw-w64-x86_64-openblas mingw-w64-x86_64-blas mingw-w64-x86_64-netcdf mingw-w64-x86_64-lapack

Windows have a constraint with length of the files (260 if I correctly understand), so to shorten the paths, at first I turned on long paths using group policy (gpedit.msc), and moved to the C:/ dir:

# Move `Trilinos` dir to the C:/ to shorten the length of paths
cd /c/Trilinos

Keyword restrict (__restrict)

Last point is the restrict keyword that ruins some packages:

Tacho_Lapack_Team.hpp -> replace __restrict__ with macro KOKKOS_RESTRICT (25 occurences)
Tacho_Blas_Team.hpp -> replace __restrict__ with macro KOKKOS_RESTRICT (65 occurences)
Tacho_LDL_Eternal.hpp -> replace __restrict__ with macro KOKKOS_RESTRICT (7 occurences)
Tacho_LU_Eternal.hpp -> replace __restrict__ with macro KOKKOS_RESTRICT (4 occurences), ...
(Just replace within entire solution (Alt+A in VS22))

As a result result I have Trilinos here:

I checked my installation on my project, and everything seems to be fine:

cmake -G "Visual Studio 17 2022" `
      -DMPIEXEC_EXECUTABLE:FILEPATH="C:/Program Files/Microsoft MPI/Bin/mpiexec.exe" `
      -DMPI_C_HEADER_DIR:PATH="C:/Program Files (x86)/Microsoft SDKs/MPI/Include" `
      -DMPI_CXX_HEADER_DIR:PATH="C:/Program Files (x86)/Microsoft SDKs/MPI/Include" `
      -DMPI_C_LIB_NAMES:STRING="msmpi" `
      -DMPI_CXX_LIB_NAMES:STRING="msmpi" `
      -DMPI_msmpi_LIBRARY:FILEPATH="C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x64/msmpi.lib" `
      -DMPI_C_LIBRARIES:FILEPATH="C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x64/msmpi.lib" `
      -DMPI_CXX_LIBRARIES:FILEPATH="C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x64/msmpi.lib" `
      -DMPI_C_COMPILER="cl.exe" `
      -DMPI_CXX_COMPILER="cl.exe" `
      ..

VS22 sees includes:

ViNN280801 · 2024-08-07T11:36:04Z

And I have a user-friendly suggestion - it'll be very convenient if Trilinos has precompiled files for different architechtures, like mpi, tbb, gmsh, and others have. Because:

Compiling Trilinos is very difficult, comprehensive process that takes an incredibly long time;
It's not so convenient to compile it manually (yes, it's cool CMake/Make experience, I agree with it)
This will allow you to have different versions of pre-compiled packages for different architectures

jhux2 · 2024-08-07T17:54:03Z

This PR should be set to merge against develop, not master.

…_20240809_175814 Automatically Merged using Trilinos Master Merge AutoTester PR Title: b'Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20240809_175814 branch to master' PR Author: trilinos-autotester

trilinos-autotester · 2024-08-10T10:14:45Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

…'__restrict' keyword instead of Linux '__restrict__'. So, all occurences with '__restrict__' replaced with 'KOKKOS_RESTRICT' macro to provide correct compilation under MSVC

trilinos-autotester · 2024-08-11T10:14:45Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2024-08-12T10:14:45Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

trilinos-autotester · 2024-08-13T10:14:55Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

iyamazaki · 2024-08-13T14:08:26Z

Thank you for the changes, @ViNN280801!! I am locally building just to be sure. So, the main changes are to replace __restrict__ with KOKKOS_RESTRICT in Tacho?

ViNN280801 · 2024-08-13T14:22:30Z

@iyamazaki, yes, just replace all __restrict__ occurences with KOKKOS_RESTRICT, because Windows has its own __restrict keyword, so, while compiling Tacho I encountered with such "syntax" errors.

iyamazaki

Thank you, @ViNN280801! I could also build and run example on V100.

dalg24 · 2024-08-13T18:44:25Z

Presumably you want to target the develop branch though?

ViNN280801 · 2024-08-13T18:47:39Z

@dalg24, yes, of course. @cgcgcg suggested me to opennew PR, I don't know have you seen it already or not (#13342), in that PR I consider only this problem with __restrict__/__restrict keyword and compilation. And that PR is for develop branch.

ViNN280801 · 2024-08-13T18:50:02Z

And I wanted to ask u about helping with such kind of problems.

Do you need to fix these problems for the Windows? I think, I can help you with this (compile Trilinos without any errors at all using MSVC Visual Studio 17 2022). But only if project really needs to be compiled on Windows.

iyamazaki · 2024-08-13T18:57:36Z

Sorry.. I thought it has been already changed, can you switch to merge into develop branch.

The base branch was changed.

ViNN280801 · 2024-08-13T18:59:58Z

@iyamazaki, done!

trilinos-autotester · 2024-08-14T03:08:08Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2024-08-14T03:14:13Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 367
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_gcc

Build Num: 417
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 418
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_clang

Build Num: 416
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4375
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_cuda

Build Num: 415
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_intel

Build Num: 336
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_cuda-uvm

Build Num: 415
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Using Repos:

Repo: TRILINOS (ViNN280801/Trilinos)

Pull Request Author: ViNN280801

trilinos-autotester · 2024-08-14T05:23:18Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 367
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_gcc

Build Num: 417
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 418
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_clang

Build Num: 416
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4375
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_cuda

Build Num: 415
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_intel

Build Num: 336
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

Build Information

Test Name: PR_cuda-uvm

Build Num: 415
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU
PULLREQUESTNUM	13319
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/ViNN280801/Trilinos
TRILINOS_SOURCE_SHA	`4e273a8`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`5381b5e`

CDash Test Results for PR# 13319.

trilinos-autotester · 2024-08-14T05:23:36Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

trilinos-autotester · 2024-08-14T05:23:42Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

trilinos-autotester · 2024-08-14T13:48:53Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ iyamazaki ]!

trilinos-autotester · 2024-08-14T13:48:59Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2024-08-14T13:49:12Z

Merge on Pull Request# 13319: IS A SUCCESS - Pull Request successfully merged

trilinos-autotester and others added 4 commits July 12, 2024 22:50

Corrected functions to compile with VS2022

ae6107a

ViNN280801 requested a review from a team as a code owner August 4, 2024 17:24

trilinos-autotester and others added 2 commits August 9, 2024 22:51

Merge branch 'trilinos:master' into fix-msvc-compilation

5baf61b

Fixing 'syntax errors' when compiling under MSVC. In Windows OS used …

bcf8266

…'__restrict' keyword instead of Linux '__restrict__'. So, all occurences with '__restrict__' replaced with 'KOKKOS_RESTRICT' macro to provide correct compilation under MSVC

ViNN280801 requested a review from a team as a code owner August 10, 2024 10:30

Return Kokkos_View.hpp to the prev version

4e273a8

cgcgcg removed the request for review from a team August 12, 2024 18:55

cgcgcg added pkg: ShyLU AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Aug 12, 2024

cgcgcg requested a review from iyamazaki August 12, 2024 18:56

iyamazaki previously approved these changes Aug 13, 2024

View reviewed changes

iyamazaki self-requested a review August 13, 2024 18:56

ViNN280801 changed the base branch from master to develop August 13, 2024 18:59

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Aug 14, 2024

iyamazaki approved these changes Aug 14, 2024

View reviewed changes

cgcgcg added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 14, 2024

trilinos-autotester merged commit 8674d3e into trilinos:develop Aug 14, 2024
18 of 30 checks passed

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Aug 14, 2024

Corrected functions to compile with VS2022 #13319

Corrected functions to compile with VS2022 #13319

Conversation

ViNN280801 commented Aug 4, 2024

Motivation

Testing

Additional Information

Request for Improved Windows Support

cgcgcg commented Aug 4, 2024

ViNN280801 commented Aug 4, 2024

cgcgcg commented Aug 4, 2024

ViNN280801 commented Aug 4, 2024

cgcgcg commented Aug 4, 2024

ViNN280801 commented Aug 6, 2024 • edited Loading

cgcgcg commented Aug 6, 2024

ndellingwood commented Aug 6, 2024

trilinos-autotester commented Aug 6, 2024

ViNN280801 commented Aug 7, 2024 • edited Loading

Keyword restrict (__restrict)

ViNN280801 commented Aug 7, 2024

jhux2 commented Aug 7, 2024

trilinos-autotester commented Aug 10, 2024

trilinos-autotester commented Aug 11, 2024

trilinos-autotester commented Aug 12, 2024

trilinos-autotester commented Aug 13, 2024

iyamazaki commented Aug 13, 2024

ViNN280801 commented Aug 13, 2024

iyamazaki left a comment

Choose a reason for hiding this comment

dalg24 commented Aug 13, 2024

ViNN280801 commented Aug 13, 2024

ViNN280801 commented Aug 13, 2024 • edited Loading

iyamazaki commented Aug 13, 2024

ViNN280801 commented Aug 13, 2024 • edited Loading

trilinos-autotester commented Aug 14, 2024

trilinos-autotester commented Aug 14, 2024

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Aug 14, 2024

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

ViNN280801 commented Aug 6, 2024 •

edited

Loading

ViNN280801 commented Aug 7, 2024 •

edited

Loading

ViNN280801 commented Aug 13, 2024 •

edited

Loading

ViNN280801 commented Aug 13, 2024 •

edited

Loading