Fix some build errors with HIP unified memory #13366

vbrunini · 2024-08-19T15:44:28Z

Fix some HIP build errors when enabling Kokkos_ENABLE_IMPL_HIP_UNIFIED_MEMORY=ON

…N between declarationa nd definition.

vbrunini · 2024-08-19T15:45:27Z

trilinos-autotester · 2024-08-19T17:20:50Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

ndellingwood · 2024-08-19T19:30:54Z

packages/amesos2/src/Amesos2_Umfpack_FunctionMap.hpp

@@ -98,16 +98,16 @@ namespace Amesos2 {
 #ifdef HAVE_TEUCHOS_COMPLEX

  template <>
-  struct FunctionMap<Umfpack,std::complex<double>>
+  struct FunctionMap<Umfpack,Kokkos::complex<double>>


@vbrunini thanks for the submission. I don't believe Kokkos::complex is convertible to std::complex, I think for these changes in the FunctionMap an added partial specialization of Kokkos::complex is needed rather than replacing the std::complex, could you make that change? For now, that will involve some code duplication

Kokkos::complex is convertible to std::complex, see https://github.com/kokkos/kokkos/blob/16eca672987e5e20d4ccd2407d262f655eae1fcf/core/src/Kokkos_Complex.hpp#L104 so I think this is fine as-is here.

@ndellingwood bump

ndellingwood · 2024-08-19T19:32:08Z

packages/amesos2/src/Amesos2_Umfpack_TypeMap.hpp

@@ -117,14 +117,14 @@ struct TypeMap<Umfpack,double>
 template <>
 struct TypeMap<Umfpack,std::complex<float> > // provide conversion from std::complex<float> to std::complex<double>
 {
-  typedef std::complex<double> type;
+  typedef Kokkos::complex<double> type;


Similar to the above, I think this need additional specializations for Kokkos::complex (which would include the Kokkos::complex typedef, rather than replacing the std::complex)

Concern addressed

trilinos-autotester · 2024-09-05T18:23:39Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2024-09-05T18:23:45Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2024-09-05T18:29:27Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 467
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc

Build Num: 517
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 518
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_clang

Build Num: 516
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4475
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda

Build Num: 515
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_intel

Build Num: 436
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda-uvm

Build Num: 515
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Using Repos:

Repo: TRILINOS (vbrunini/Trilinos)

Pull Request Author: vbrunini

trilinos-autotester · 2024-09-05T20:53:35Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 467
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc

Build Num: 517
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 518
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_clang

Build Num: 516
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4475
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda

Build Num: 515
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_intel

Build Num: 436
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda-uvm

Build Num: 515
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

CDash Test Results for PR# 13366.

Wiki: How to Reproduce PR Testing Builds and Errors.

sebrowne · 2024-09-06T14:58:08Z

This got hit with a bug in Framework unit testing, RETEST is an appropriate fix (that testing has been disabled).

trilinos-autotester · 2024-09-06T17:18:42Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2024-09-06T17:24:13Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 477
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc

Build Num: 527
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 528
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_clang

Build Num: 526
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4485
Status: STARTED

Jenkins Parameters

Parameter Name	Value
BLOCKING_BUILD	false
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda

Build Num: 525
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_intel

Build Num: 446
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda-uvm

Build Num: 525
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Using Repos:

Repo: TRILINOS (vbrunini/Trilinos)

Pull Request Author: vbrunini

trilinos-autotester · 2024-09-06T19:55:30Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 477
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc

Build Num: 527
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 528
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_clang

Build Num: 526
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 4485
Status: PASSED

Jenkins Parameters

Parameter Name	Value
BLOCKING_BUILD	false
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda

Build Num: 525
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_intel

Build Num: 446
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

Build Information

Test Name: PR_cuda-uvm

Build Num: 525
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	13366
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/vbrunini/Trilinos
TRILINOS_SOURCE_SHA	`826b8ee`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`3ef94db`

CDash Test Results for PR# 13366.

trilinos-autotester · 2024-09-06T19:55:51Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ brian-kelley ]!

trilinos-autotester · 2024-09-06T19:55:58Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

vbrunini added 3 commits August 19, 2024 08:41

tacho: Fix compile errors with Kokkos_ENABLE_IMPL_HIP_UNIFIED_MEMORY=ON.

0f602c8

amesos2: Fix UMFPACK building with HIP.

fd5dc88

minitensor: Fix HIP build error from mismatched KOKKOS_INLINE_FUNCTIO…

826b8ee

…N between declarationa nd definition.

vbrunini requested review from a team as code owners August 19, 2024 15:44

vbrunini changed the base branch from master to develop August 19, 2024 15:44

ndellingwood previously requested changes Aug 19, 2024

View reviewed changes

ndellingwood added AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration labels Sep 5, 2024

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 5, 2024

brian-kelley approved these changes Sep 5, 2024

View reviewed changes

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Sep 5, 2024

ndellingwood added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Sep 6, 2024

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Sep 6, 2024

ndellingwood merged commit 446b5b0 into trilinos:develop Sep 6, 2024
19 of 29 checks passed

Fix some build errors with HIP unified memory #13366

Fix some build errors with HIP unified memory #13366

Conversation

vbrunini commented Aug 19, 2024

vbrunini commented Aug 19, 2024

trilinos-autotester commented Aug 19, 2024

ndellingwood Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

vbrunini Aug 19, 2024

Choose a reason for hiding this comment

vbrunini Aug 27, 2024

Choose a reason for hiding this comment

ndellingwood Aug 19, 2024

Choose a reason for hiding this comment

trilinos-autotester commented Sep 5, 2024

trilinos-autotester commented Sep 5, 2024

trilinos-autotester commented Sep 5, 2024

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Sep 5, 2024

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

sebrowne commented Sep 6, 2024

trilinos-autotester commented Sep 6, 2024

trilinos-autotester commented Sep 6, 2024

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

ndellingwood Aug 19, 2024 •

edited

Loading