Tpetra: Don't access DualView's [h|d]_view directly #13778
+152
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Arndt <[email protected]>
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
masterleinad
changed the title
masterleinad
commented
Feb 4, 2025
| // DEEP_COPY REVIEW - DEVICE-TO-HOSTMIRROR | ||
| Kokkos::deep_copy (execution_space(), devView, hostView); | ||
| dv = dual_view_type (devView, hostView); | ||
| execution_space().fence(); |
There was a problem hiding this comment.
This fence is new but seems necessary. The constructor will not fence and the deep_copy is asynchronous. The function doesn't take an execution space instance argument so it should be synchronous.
ndellingwood
added
the
AT: PRE-TEST INSPECTED
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: masterleinad |
maartenarnst
reviewed
Feb 4, 2025
| @@ -29,8 +29,8 @@ | |||
| if (envVarSet && (std::strcmp(envVarSet,"1") == 0)) \ | |||
| std::cout << (fn) << " called from " << callerstr \ | |||
| << " at " << filestr << ":"<<linnum \ | |||
| << " host cnt " << dualView.h_view.use_count() \ | |||
| << " device cnt " << dualView.d_view.use_count() \ | |||
| << " host cnt " << dualView.view_host().use_count() \ | |||
There was a problem hiding this comment.
I’m not sure if it’s an issue, but here, behavior changes, right? Because the getter is making a copy, so we’ll now report the previous use count incremented by one.
There was a problem hiding this comment.
Yes, in general all use counts will be larger but from what I understand only the difference between host and device is of relevance here.
maartenarnst
reviewed
Feb 4, 2025
| @@ -210,7 +210,7 @@ class WrappedDualView { | |||
| } | |||
|
|
|||
| size_t extent(const int i) const { | |||
| return dualView.h_view.extent(i); | |||
| return dualView.view_host().extent(i); | |||
There was a problem hiding this comment.
This can probably become just dualView.extent(i).
maartenarnst
reviewed
Feb 4, 2025
| @@ -551,11 +551,11 @@ class WrappedDualView { | |||
| } | |||
|
|
|||
| int host_view_use_count() const { | |||
| return originalDualView.h_view.use_count(); | |||
| return originalDualView.view_host().use_count(); | |||
There was a problem hiding this comment.
Here, the increment by one may be worth considering. Similar cases below.
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Signed-off-by: Daniel Arndt <[email protected]>
jhux2
added
AT: RETEST
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
trilinos-autotester
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: masterleinad |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: PR_gcc-openmpi-openmp
Jenkins Parameters
Build InformationTest Name: PR_gcc
Jenkins Parameters
Build InformationTest Name: PR_gcc-openmpi_debug
Jenkins Parameters
Build InformationTest Name: PR_clang
Jenkins Parameters
Build InformationTest Name: PR_cuda
Jenkins Parameters
Build InformationTest Name: PR_intel
Jenkins Parameters
Build InformationTest Name: PR_cuda-uvm
Jenkins Parameters
|
trilinos-autotester
removed
the
AT: RETEST
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra
Motivation
kokkos/kokkos#7716 proposes to deprecate the ability to access
DualView'sh_viewandd_viewmembers directly since modifying the allocations can get perturbed theDualView's internal status. This pull request replaces all places inTpetrathat use these members directly, in most places, verbatim withview_deviceresp.view_host.Related Issues
Related to kokkos/kokkos#7716.
Testing
Compiling Trilinos with
Tpetraenabled with the OpenMP backend and running theTpetratests.Signed-off-by: Daniel Arndt [email protected]