Skip to content

Commit

Permalink
expo: Add a little more cedit CMOS logging
Browse files Browse the repository at this point in the history
Add some more logging in the CMOS read/write code. Tidy up a few
comments while we are here.

Signed-off-by: Simon Glass <[email protected]>
  • Loading branch information
sjg20 committed Oct 18, 2024
1 parent 012e1e8 commit f698786
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions boot/cedit.c
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ static int h_read_settings_env(struct scene_obj *obj, void *vpriv)

/*
* note that no validation is done here, to make sure the ID is
* valid * and actually points to a menu item
* valid and actually points to a menu item
*/
menu->cur_item_id = val;
break;
Expand Down Expand Up @@ -718,6 +718,7 @@ int cedit_write_settings_cmos(struct expo *exp, struct udevice *dev,
}

/* write the data to the RTC */
log_debug("Writing CMOS\n");
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {
Expand Down Expand Up @@ -785,6 +786,7 @@ static int h_read_settings_cmos(struct scene_obj *obj, void *vpriv)
}

/* update the current item */
log_debug("look for menuitem value %d in menu %d\n", val, menu->obj.id);
mi = scene_menuitem_find_seq(menu, val);
if (!mi)
return log_msg_ret("seq", -ENOENT);
Expand Down Expand Up @@ -819,7 +821,7 @@ int cedit_read_settings_cmos(struct expo *exp, struct udevice *dev,
goto done;
}

/* read the data to the RTC */
/* indicate what bytes were read from the RTC */
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {
Expand Down

0 comments on commit f698786

Please sign in to comment.