Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full configuration binding needed #23

Open
Randgalt opened this issue May 23, 2024 · 2 comments
Open

Full configuration binding needed #23

Randgalt opened this issue May 23, 2024 · 2 comments

Comments

@Randgalt
Copy link
Member

Randgalt commented May 23, 2024

Across the board configurations needed using Airlift ConfigBinder so that HTTP connection config can be set, etc. Affected areas:

  • TrinoS3ProxyServerModule
  • TrinoS3ProxyClient

etc.

@vagaerg
Copy link
Member

vagaerg commented Jun 6, 2024

Would the binding done here: https://github.com/trinodb/s3-proxy/blob/83e31e95311a09923beff7b332797fb76e123bcd/trino-s3-proxy/src/main/java/io/trino/s3/proxy/server/TrinoS3ProxyServerModule.java#L48-L55

be sufficient? Or would the airlift HTTP client etc be in a different context?

@Randgalt
Copy link
Member Author

Randgalt commented Jun 6, 2024

In Galaxy, we have a retrying wrapper around the HTTP client. We can do that later though. There are other TODOs in the code base that need config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants