Allow path-style addressing when proxy is using virtual host #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagaerg
reviewed
Aug 14, 2024
| @@ -98,7 +98,7 @@ record BucketAndKey(String bucket, String rawKey) {} | |||
| .flatMap(serverHostNameValue -> { | |||
| String lowercaseServerHostName = serverHostNameValue.toLowerCase(Locale.ROOT); | |||
| return Optional.of(request.requestUri().getHost()) | |||
| .filter(value -> value.endsWith(lowercaseServerHostName)) | |||
| .filter(value -> value.endsWith(lowercaseServerHostName) && !value.equals(lowercaseServerHostName)) | |||
There was a problem hiding this comment.
I believe that you can now remove the endsWith(".") check below right? You can simply make serverHostNameValue start with a .. That has two advantages:
- It would remove the need for you to check
!value.equals(lowercaseServerHostName) - You can also remove the check on line 103 to ensure the bucket doesn't end with a
.
vagaerg
approved these changes
Aug 14, 2024
mosiac1
force-pushed
the
feat/accept-path-on-virtual-host
branch
from
dcdef03 to
2eadbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of
RequestFilterso that:some-bucket.${hostname}/some-objectthenbucket=some-bucketandkey=some-key;