Enforce ErrorProne MissingOverride

trinodb · Jan 8, 2024 · 9271e22 · 9271e22
1 parent 579510b
commit 9271e22
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 0 deletions.
diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java b/gateway-ha/src/main/java/io/trino/gateway/ha/clustermonitor/ActiveClusterMonitor.java
@@ -68,6 +68,7 @@ public ActiveClusterMonitor(
     /**
      * Run an app that queries all active trino clusters for stats.
      */
+    @Override
     public void start()
     {
         singleTaskExecutor.submit(
@@ -110,6 +111,7 @@ public void start()
     /**
      * Shut down the app.
      */
+    @Override
     public void stop()
     {
         this.monitorActive = false;

diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java b/gateway-ha/src/main/java/io/trino/gateway/ha/handler/QueryIdCachingProxyHandler.java
@@ -314,6 +314,7 @@ public String rewriteTarget(HttpServletRequest request)
         return targetLocation;
     }
 
+    @Override
     protected void postConnectionHook(
             HttpServletRequest request,
             HttpServletResponse response,

diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java b/gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java
@@ -130,6 +130,7 @@ public void activateBackend(String backendName)
         }
     }
 
+    @Override
     public ProxyBackendConfiguration addBackend(ProxyBackendConfiguration backend)
     {
         try {
@@ -142,6 +143,7 @@ public ProxyBackendConfiguration addBackend(ProxyBackendConfiguration backend)
         return backend;
     }
 
+    @Override
     public ProxyBackendConfiguration updateBackend(ProxyBackendConfiguration backend)
     {
         try {

diff --git a/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java b/gateway-ha/src/main/java/io/trino/gateway/ha/security/LbOAuthManager.java
@@ -211,6 +211,7 @@ public String getExpiresIn()
             return this.expiresIn;
         }
 
+        @Override
         public boolean equals(final Object o)
         {
             if (o == this) {
@@ -249,6 +250,7 @@ public boolean equals(final Object o)
             return Objects.equals(expiresIn, otherExpiresIn);
         }
 
+        @Override
         public int hashCode()
         {
             final int prime = 59;
@@ -268,6 +270,7 @@ public int hashCode()
             return result;
         }
 
+        @Override
         public String toString()
         {
             return "LbOAuthManager.OidcTokens(accessToken=" + this.getAccessToken() +

diff --git a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/ProxyServletImpl.java
@@ -102,6 +102,7 @@ protected String rewriteTarget(HttpServletRequest request)
     /**
      * Customize the response returned from remote server.
      */
+    @Override
     protected void onResponseContent(
             HttpServletRequest request,
             HttpServletResponse response,

diff --git a/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java b/gateway-ha/src/main/java/io/trino/gateway/proxyserver/RequestFilter.java
@@ -31,17 +31,20 @@ public class RequestFilter
 {
     private FilterConfig filterConfig;
 
+    @Override
     public void init(FilterConfig filterConfig)
             throws ServletException
     {
         this.filterConfig = filterConfig;
     }
 
+    @Override
     public void destroy()
     {
         this.filterConfig = null;
     }
 
+    @Override
     public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
             throws IOException, ServletException
     {

diff --git a/...ay-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java b/...ay-ha/src/main/java/io/trino/gateway/proxyserver/wrapper/MultiReadHttpServletRequest.java
@@ -122,6 +122,7 @@ public boolean isReady()
             @Override
             public void setReadListener(ReadListener readListener) {}
 
+            @Override
             public int read()
                     throws IOException
             {

diff --git a/pom.xml b/pom.xml
@@ -115,6 +115,7 @@
                         <arg>-XDcompilePolicy=simple</arg>
                         <arg>
                             -Xplugin:ErrorProne
+                            -Xep:MissingOverride:ERROR \
                             <!-- TODO: Enable DoubleBraceInitialization flag -->
                             -Xep:DoubleBraceInitialization:OFF
                         </arg>