Remove redundant code #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/clean
branch
2 times, most recently
from
8b20f31 to
35b2e31
Compare
ebyhr
force-pushed
the
ebi/clean
branch
2 times, most recently
from
9b984d9 to
8e9ddf7
Compare
|
This goes very far in removing code... can you please explain reasoning for the various removals in the commit message or split things up into separate commits that have more info? We need to be sure we are not removing stuff that is actually used or needed and we just dont know details yet. I would also love some input after these details are provided from @willmostly @vishalya and @Chaho12 |
mosabua
requested changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.