Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COMPACT_NO_ARRAY checkstyle failure #126

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Fix COMPACT_NO_ARRAY checkstyle failure #126

merged 1 commit into from
Dec 31, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Dec 31, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Dec 31, 2023
@ebyhr ebyhr requested review from wendigo and mosabua December 31, 2023 05:56
mosabua
mosabua approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change.. but how would we allow multiple roles.. is the array syntax allowed then?

@wendigo
Copy link
Contributor

wendigo commented Dec 31, 2023

@mosabua Yes

@wendigo wendigo merged commit 8ba4f93 into main Dec 31, 2023
1 check passed
@wendigo wendigo deleted the ebi/annotation branch December 31, 2023 08:10
@mosabua mosabua mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @wendigo @mosabua