Add logging for flaky test #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
approved these changes
Jan 10, 2024
ebyhr
reviewed
Jan 10, 2024
| @@ -123,6 +127,9 @@ public void testByRoutingRulesEngineFileChange() | |||
| + "actions:\n" | |||
| + " - \"result.put(\\\"routingGroup\\\", \\\"etl\\\")\""); | |||
| fw.close(); | |||
| file.getPath(); | |||
| long etlLastModified = file.lastModified(); | |||
| log.info("etl rule file created at: " + etlLastModified); | |||
There was a problem hiding this comment.
No need to change as temporal code, but we cloud use logger template:
log.info("etl rule file created at: {}", etlLastModified);| @@ -147,6 +154,9 @@ public void testByRoutingRulesEngineFileChange() | |||
| + "actions:\n" | |||
| + " - \"result.put(\\\"routingGroup\\\", \\\"etl2\\\")\""); // change from etl to etl2 | |||
| fw.close(); | |||
| long etl2LastModified = file.lastModified(); | |||
| log.info("etl2 rule file created at: " + etl2LastModified); | |||
| assertNotEquals(etl2LastModified, etlLastModified); | |||
There was a problem hiding this comment.
nit: We could include message in assertion method instead of logging:
assertNotEquals(long unexpected, long actual, String message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address 123, we need to first add logging to determine if the file change is detectable by comparing timestamps with millisecond precision.