Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule file test #160

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix rule file test #160

merged 1 commit into from
Jan 12, 2024

Conversation

willmostly
Copy link
Contributor

@willmostly willmostly commented Jan 11, 2024 •
edited by ebyhr
Loading

Fixes #123

@cla-bot cla-bot bot added the cla-signed label Jan 11, 2024
@willmostly willmostly force-pushed the fix-rule-file-test branch 2 times, most recently from e666fbd to b3626e1 Compare January 11, 2024 19:00
@mosabua
Copy link
Member

mosabua commented Jan 11, 2024

Once the conflict is resolved this should be good to go.

@ebyhr
Copy link
Member

ebyhr commented Jan 12, 2024

I think setting the last modified time #161 is better.

@willmostly
Copy link
Contributor Author

I think setting the last modified time #161 is better.

this fix sets lastModifiedTime here

@willmostly willmostly requested a review from ebyhr January 12, 2024 03:30
@willmostly willmostly requested a review from ebyhr January 12, 2024 03:47
@ebyhr ebyhr merged commit 1c2cb33 into trinodb:main Jan 12, 2024
1 check passed
@ebyhr
Copy link
Member

ebyhr commented Jan 12, 2024

Merged, thanks!

@mosabua mosabua mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua left review comments

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky TestRoutingGroupSelector.testByRoutingRulesEngineFileChange
3 participants
@willmostly @mosabua @ebyhr