Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup in TestTcpChecks #176

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Minor cleanup in TestTcpChecks #176

merged 1 commit into from
Jan 20, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 20, 2024

No description provided.

- Remove redundant constants
- Throws Exception
- Fix typo
@cla-bot cla-bot bot added the cla-signed label Jan 20, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and definitely cleaner than before.

@@ -36,13 +35,8 @@
@TestInstance(PER_CLASS)
public class TestTcpChecks
{
public static final String TRINO_SOURCE_HEADER = "X-Trino-Source";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So those were not even used?

@ebyhr ebyhr merged commit 9a100ec into trinodb:main Jan 20, 2024
2 checks passed
@ebyhr ebyhr deleted the ebi/TestTcpChecks branch January 20, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants