Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navigation for docs #178

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Improve navigation for docs #178

merged 1 commit into from
Jan 26, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 22, 2024

  • Add logo on each page
  • Use same layout in readme
  • Use only three columns but add item lists

Please review @willmostly @vishalya @Chaho12

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2024
@mosabua mosabua force-pushed the docs-nav branch 3 times, most recently from cad9f43 to cb79344 Compare January 22, 2024 22:09
@mosabua mosabua marked this pull request as ready for review January 22, 2024 22:09
- Add logo on each page
- Use same layout in readme
- Use only three columns but add item lists
Copy link
Member

@Chaho12 Chaho12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess no more bolding current page link?

LGTM 👍

@mosabua
Copy link
Member Author

mosabua commented Jan 24, 2024

I guess no more bolding current page link?

No .. ultimately I think we need to get a little website that deploys to github pages via a different branch going. I know how to do all that .. just need to figure out how this relates to plans I have with the Trino docs themselves..

Copy link
Contributor

@willmostly willmostly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It will be nice once Sphinx is introduced so we don't have to change each doc page manually.

@mosabua
Copy link
Member Author

mosabua commented Jan 26, 2024

Thank you @ebyhr @willmostly and @Chaho12

@mosabua mosabua merged commit ffa6ecc into trinodb:main Jan 26, 2024
2 checks passed
@mosabua mosabua deleted the docs-nav branch January 26, 2024 23:57
@github-actions github-actions bot added this to the 6 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants