Update MySQL JDBC driver to 9.0.0 #482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Sep 25, 2024
| @@ -24,7 +24,7 @@ | |||
| <dep.jeasy.version>4.1.0</dep.jeasy.version> | |||
| <dep.mockito.version>5.13.0</dep.mockito.version> | |||
| <dep.okhttp3.version>4.12.0</dep.okhttp3.version> | |||
| <dep.mysqlconnector.version>8.3.0</dep.mysqlconnector.version> | |||
| <dep.mysqlconnector.version>9.0.0</dep.mysqlconnector.version> | |||
There was a problem hiding this comment.
Trino user reported 8.4.0 caused performance regression. trinodb/trino#21945
I'm not sure whether this version is safe to use.
There was a problem hiding this comment.
Hmm.. good question.. I guess we would need to try with 9.0.0 in Trino as well and decide from there.
|
@mosabua we should update the image used by the runner, regardless of 8.3 vs 9 for the driver version. It looks like none of the tests use a MySQL image 😬 |
Sounds good .. I will try to attack this at some stage soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) Release notes are required, with the following suggested text:
* tbd .. probably affects what MySQL version we support