Allow setting config values from env variables #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
Sep 27, 2024
gateway-ha/src/main/java/io/trino/gateway/ha/util/ConfigurationUtils.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/util/ConfigurationUtilsTest.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/util/ConfigurationUtilsTest.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/util/ConfigurationUtilsTest.java
Outdated
Show resolved
Hide resolved
gateway-ha/src/test/java/io/trino/gateway/ha/util/ConfigurationUtilsTest.java
Outdated
Show resolved
Hide resolved
oneonestar
force-pushed
the
star/env_config
branch
from
c712e57
to
2d9ad29
Compare
ndrluis
reviewed
Sep 27, 2024
oneonestar
force-pushed
the
star/env_config
branch
from
2d9ad29
to
526fb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow setting config values from env variables.
Additional context and related issues
This is the same syntax used by Trino: https://trino.io/docs/current/security/secrets.html
Release notes
(x) Release notes are required, with the following suggested text:
* Allow setting config values from environment variables