Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config file path in Docker image #628

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

oneonestar
Copy link
Member

@oneonestar oneonestar commented Feb 20, 2025

Description

Refactor /opt/trino-gateway/config.yaml to /etc/trino-gateway/config.yaml.

I made a mistake in #623.
We should use the same file path in the Docker image and the chart to avoid confusion.
This also consist with Trino's config path /etc/trino.

Release notes

(x) Release notes are required, with the following suggested text:

* [:warning: Breaking change:](#breaking) Change configuration file name in Docker image from 
  `/opt/trino/gateway-ha-config.yml` to `/etc/trino-gateway/config.yaml`.

@cla-bot cla-bot bot added the cla-signed label Feb 20, 2025
@oneonestar oneonestar requested a review from mosabua February 20, 2025 01:23
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Will you send a PR for the charts if needed @oneonestar ?

@mosabua mosabua merged commit fa85a7b into trinodb:main Feb 26, 2025
2 checks passed
@github-actions github-actions bot added this to the 15 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants