implement get_catalog_names
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovaesco
reviewed
Aug 16, 2023
| @@ -192,6 +192,16 @@ def get_foreign_keys( | |||
| """Trino has no support for foreign keys. Returns an empty list.""" | |||
| return [] | |||
|
|
|||
| def get_catalog_names(self, connection: Connection, **kw) -> List[str]: | |||
Signed-off-by: Đặng Minh Dũng <[email protected]>
dungdm93
force-pushed
the
feature/get_catalog_names
branch
from
b1f0621
to
0e2b529
Compare
hovaesco
approved these changes
Aug 31, 2023
hashhar
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to provide standard function
get_catalog_namesin SQLAlchemy'sTrinoDialect.This function could be used to list and switch between catalogs by client like proposed in Superset SIP-95
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: