Add a generic function compiler to handle IGNORE NULLS in window functions
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovaesco
reviewed
Dec 21, 2023
hovaesco
approved these changes
Dec 22, 2023
|
Please squash commits and rebase on master. |
laserkaplan
force-pushed
the
ignore-nulls
branch
3 times, most recently
from
4312668
to
1ba5e43
Compare
Took a couple of tries but done now :P |
laserkaplan
force-pushed
the
ignore-nulls
branch
from
1ba5e43
to
b82beed
Compare
hovaesco
approved these changes
Dec 28, 2023
hashhar
approved these changes
Jan 18, 2024
Add a generic function compiler to handle IGNORE NULLS in window functions.
|
just reworded the commit message for release note's sake. Merging. |
evansd
added a commit
to opensafely-core/ehrql
that referenced
this pull request
Feb 27, 2024
This doesn't benefit us at all (it's designed to avoid the compilation overhead when executing the same SQL over and over) and it leads to warnings when we execute clause elements whose caching behaviour has not be explicitly defined. We're getting a warning here now because we've just updated to Trino v0.328.0 which includes this PR: * trinodb/trino-python-client#429 This defines a compiler for the `Lag` clause which (because it is not restricted to a specific dialect) ends up being used by SQLite and triggering the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a simple compiler method for using the
IGNORE NULLSfunctionality of window functions in Trino. I implemented this privately in a package for work but figured I could generalize it and add it to the package as a whole :)Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: