Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set log level for the root logger #434

Merged
merged 1 commit into from
Dec 27, 2023
+11 −2
Merged

Only set log level for the root logger #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions trino/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,21 @@
# limitations under the License.

import logging
from typing import Optional

LEVEL = logging.INFO


# TODO: provide interface to use ``logging.dictConfig``
def get_logger(name: str, log_level: int = LEVEL) -> logging.Logger:
def get_logger(name: str, log_level: Optional[int] = None) -> logging.Logger:
logger = logging.getLogger(name)
logger.setLevel(log_level)
# We must not call setLevel by default except on the root logger otherwise
# we cannot change log levels for all modules by changing level of the root
# logger
if log_level is not None:
logger.setLevel(log_level)
return logger


# set default log level to LEVEL
trino_root_logger = get_logger('trino', LEVEL)