Remove normalize method from TemporalType #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this PR does it. It just removes dead code. We're missing tests for values which lie in DST gap or are doubled. The existing tests for this which were added in the beginning only worked in the timezone of the author, not CI, in CI the session zone is such that those values don't create DST ambiguities. Please adjust commit message to say something like |
hovaesco
force-pushed
the
hovaesco/drop-normalize
branch
from
332c1dc
to
881f3e8
Compare
|
Adjusted the commit message. |
hashhar
approved these changes
Aug 2, 2024
|
please mind ci. |
This code has been dead/broken since 2b9ca0c
hovaesco
force-pushed
the
hovaesco/drop-normalize
branch
from
2b8e87d
to
2410e3b
Compare
Due to the compability issue with krb5 newest release.
hovaesco
force-pushed
the
hovaesco/drop-normalize
branch
from
1273e35
to
f0a5305
Compare
|
@hashhar please have a look at two last commits which fix CI. |
hashhar
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove normalize method from TemporalType.
Related to #449
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: