-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DML with properties in engine + Add support for branching in Iceberg #24556
Open
ebyhr
wants to merge
3
commits into
trinodb:master
Choose a base branch
from
ebyhr:ebi/iceberg-tag-branch-writes-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
2a6ee7f
to
60394b8
Compare
42baa70
to
a797e04
Compare
a797e04
to
571c906
Compare
571c906
to
4948981
Compare
4948981
to
9edb316
Compare
ebyhr
commented
Feb 7, 2025
Comment on lines
+5868
to
+5871
if (table.getBranch().isPresent()) { | ||
verify(table.getQueryPeriod().isEmpty(), "query period must be empty"); | ||
Optional<TableVersion> endVersion = table.getBranch().map(branch -> new TableVersion(TARGET_ID, VARCHAR, utf8Slice(branch))); | ||
return metadata.getRedirectionAwareTableHandle(session, name, Optional.empty(), endVersion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add another parameter instead of reusing the existing end-version.
9edb316
to
732ac7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 1st commit allows properties after the target table name in DML:
Avoided session property approach because users may forget the current branch and modify unexpected branch.
The 2nd commit introduces branching support and adds the following procedures in Iceberg connector:
from
up to theto
snapshot iffrom
is an ancestor ofto
.TestIcebergBranching uses that new syntax and procedures.
Relates to #12844
References
Release notes