Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more properties to iceberg $properties table #24900

Closed
wants to merge 1 commit into from

Conversation

sug-ghosh
Copy link
Contributor

Fixes #24812

Add properties to iceberg $property table.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 4, 2025
@github-actions github-actions bot added the iceberg Iceberg connector label Feb 4, 2025
@sug-ghosh sug-ghosh changed the title Add more properties to iceberg $properties table [WIP] Add more properties to iceberg $properties table Feb 5, 2025
@sug-ghosh sug-ghosh requested review from ebyhr and hashhar February 5, 2025 13:11
@sug-ghosh sug-ghosh changed the title [WIP] Add more properties to iceberg $properties table Add more properties to iceberg $properties table Feb 5, 2025
@sug-ghosh
Copy link
Contributor Author

Hi @ebyhr, can you please review this pr , thanks in advance!

@sug-ghosh sug-ghosh requested a review from pettyjamesm February 6, 2025 05:58
@ebyhr
Copy link
Member

ebyhr commented Feb 6, 2025

@sug-ghosh I'm not sure why you took over this task even though @ozakidai mentioned he is actively working on #24812. Could you close this PR and review #24922 instead?

@ebyhr ebyhr removed their request for review February 6, 2025 06:04
@ebyhr
Copy link
Member

ebyhr commented Feb 6, 2025

@sug-ghosh I merged your code and commit-authority into #24922. Let's continue review process there.

@ebyhr ebyhr closed this Feb 6, 2025
@sug-ghosh
Copy link
Contributor Author

@sug-ghosh I'm not sure why you took over this task even though @ozakidai mentioned he is actively working on #24812. Could you close this PR and review #24922 instead?

@ebyhr hey sorry, I haven't actively go through comments there actually. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

Add more properties to Iceberg $properties result
2 participants